Bugfix: Add missing dependency#144
Merged
Merged
Conversation
The `Exec[os_patching::exec::fact]` requires the
`${cache_dir}/reboot_override` file.
Collaborator
|
@theosotr thanks. Merged to dev. |
albatrossflavour
added a commit
that referenced
this pull request
Aug 21, 2019
* The declared ISO format does not exist, had one extra `dd` (#141) * Force usage of the 'C' locale (#142) When parsing command output, we should ensure the utility will emit messages in the language we are using for matching patterns. Force the locale to be 'C' by setting the LC_ALL environment variable. * link to the wiki * #128 additional queries as examples * Add missing dependency (#144) The `Exec[os_patching::exec::fact]` requires the `${cache_dir}/reboot_override` file. * Updates to facter and bug fixes (#148) * #143 try a new way of doing matching for pinned packages * Fixed typos * #147 update the fact with the new data * #147 fix ordering * #147 only create the mismatch array if the file has data in it * #147 cross linux distro compatability * #147 sles compatability * #145 add a list of KB updates to the fact * Fix handling of KBArticleIDs (#146) * Fix handling of KBArticleIDs - Ensures all KBArticleIDs are processed, not just the first one in the array - Ensures the ID's start with "KB", which aids reusing the fact info later on. * fix typo in variable typo in variable (kbslist --> kblist) on line 57 * #143 try a new way of doing matching for pinned packages * Fixed typos * #147 update the fact with the new data * #147 fix ordering * #147 only create the mismatch array if the file has data in it * #147 cross linux distro compatability * #147 sles compatability * #145 add a list of KB updates to the fact * Fix handling of KBArticleIDs (#146) * Fix handling of KBArticleIDs - Ensures all KBArticleIDs are processed, not just the first one in the array - Ensures the ID's start with "KB", which aids reusing the fact info later on. * fix typo in variable typo in variable (kbslist --> kblist) on line 57 * Fix missing slash (#147) * #143 Fix formatting and use puppet_vardir rather than puppet_client_datadir * #143 change to clientcert rather than fqdn for the catalog name * rename element to version_specified_but_not_locked_packages * Toggle to allow warnings to block patching #143 (#150) * #143 first stab at a new parameter to control VSBNLP behaviour * Try the new format for the locked files * Abort flag * update fact * #149 allow Debian to run `apt-get autoremove` at reboot (#151) * Add an option to the task to allow the running of `apt-get autoremove` after patching * #149 try both ways of doing the autoremove * #149 fix default * #149 fix default * #149 allow cron job to be removed * #149 revert changes to the task now that we are doing the autoremove via cron * Add an option to the task to allow the running of `apt-get autoremove` after patching * #149 try both ways of doing the autoremove * #149 fix default * #149 fix default * #149 allow cron job to be removed * #149 revert changes to the task now that we are doing the autoremove via cron * Pre-v0.12.0 release
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
Exec[os_patching::exec::fact]resource depends on the "${cache_dir}/reboot_override" file. Without this dependency this puppet script might fail, as follows:Tested on a Linux machine.